Wire httpx transport in gql-cli #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 3102 3127 +25
=========================================
+ Hits 3102 3127 +25 ☔ View full report in Codecov by Sentry. |
|
Ok, now I know why that other line was formatted so weirdly, to make flake8 happy. I will revert that line. |
mss
force-pushed
the
feature/gql-cli-with-httpx
branch
from
963e0c2 to
06e8de0
Compare
mss
force-pushed
the
feature/gql-cli-with-httpx
branch
from
06e8de0 to
0be45b7
Compare
|
I also added a test so codecov is hopefully happy again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that I had some problem with the
aiohttpbackend and tried to usehttpxinstead just to discover that it wasn't available.My problem was somewhere else but this change makes the
httpxbackend available for thegql-clicommand.